[
https://issues.apache.org/jira/browse/AIRFLOW-3743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16800625#comment-16800625
]
ASF subversion and git services commented on AIRFLOW-3743:
----------------------------------------------------------
Commit b3c28475c9188cdabac8313331fbf529569ce11e in airflow's branch
refs/heads/v1-10-test from Ash Berlin-Taylor
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=b3c2847 ]
[AIRFLOW-3743] Unify different methods of working out AIRFLOW_HOME (#4705)
There were a few ways of getting the AIRFLOW_HOME directory used
throughout the code base, giving possibly conflicting answer if they
weren't kept in sync:
- the AIRFLOW_HOME environment variable
- core/airflow_home from the config
- settings.AIRFLOW_HOME
- configuration.AIRFLOW_HOME
Since the home directory is used to compute the default path of the
config file to load, specifying the home directory Again in the config
file didn't make any sense to me, and I have deprecated that.
This commit makes everything in the code base use
`settings.AIRFLOW_HOME` as the source of truth, and deprecates the
core/airflow_home config option.
There was an import cycle form settings -> logging_config ->
module_loading -> settings that needed to be broken on Python 2 - so I
have moved all adjusting of sys.path in to the settings module
(This issue caused me a problem where the RBAC UI wouldn't work as it
didn't find the right webserver_config.py)
> Unify multiple ways of specifying and accessing AIRFLOW_HOME
> ------------------------------------------------------------
>
> Key: AIRFLOW-3743
> URL: https://issues.apache.org/jira/browse/AIRFLOW-3743
> Project: Apache Airflow
> Issue Type: Improvement
> Components: configuration
> Reporter: Ash Berlin-Taylor
> Assignee: Ash Berlin-Taylor
> Priority: Minor
> Fix For: 1.10.3
>
>
> We currently have two (or three, depending on how you look at it) ways of
> getting AIRFLOW_HOME
> {{airflow.configuration.AIRFLOW_HOME}}
> {{airflow.settings.AIRFLOW_HOME}}
> {{airflow.configuration.get('core', 'airflow_home')}}
> used throughout the codebase. This has led to a few odd bugs
> (https://github.com/puckel/docker-airflow/issues/225 for example) if the
> config file and environment are out-of-sync.
> Since the default path of the config file is dependent on the AIRFLOW_HOME
> environment variable I propose we remove the airflow_home from the config
> file, and unify all access in the code base to go via
> {{settings.AIRFLOW_HOME}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
