potiuk commented on a change in pull request #13323:
URL: https://github.com/apache/airflow/pull/13323#discussion_r549131593



##########
File path: scripts/ci/libraries/_start_end.sh
##########
@@ -16,6 +16,26 @@
 # specific language governing permissions and limitations
 # under the License.
 
+# Starts group for Github Actions - makes logs much more readable
+function start_end::group_start {
+    if [[ ${GITHUB_ACTIONS=} == "true" ]]; then

Review comment:
       Nope. It's OK. We have 'set -u` (fail on undefined) set in the script so 
it will fail if a variable is undefined. It helps to catch typos but in this 
case GITHUB_ACTIONS might be undefined when run locally so I (out of 
precaution) add = to make the variable value empty rather than undefined.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to