potiuk commented on a change in pull request #13329:
URL: https://github.com/apache/airflow/pull/13329#discussion_r549168430
##########
File path: scripts/ci/images/ci_verify_prod_image.sh
##########
@@ -51,41 +74,129 @@ function verify_prod_image_has_airflow_and_providers() {
echo
echo "${COLOR_RED_ERROR} Some expected providers are not
installed!${COLOR_RESET}"
echo
+ exit 1
+ else
+ echo
+ echo "${COLOR_GREEN_OK} All expected providers
installed!${COLOR_RESET}"
+ echo
fi
+ start_end::group_end
}
function verify_prod_image_dependencies() {
-
- echo
- echo "Checking if Airflow dependencies are non-conflicting in
${AIRFLOW_PROD_IMAGE} image."
- echo
+ start_end::group_start "Checking if Airflow dependencies are
non-conflicting in ${AIRFLOW_PROD_IMAGE} image."
set +e
- docker run --rm --entrypoint /bin/bash "${AIRFLOW_PROD_IMAGE}" -c 'pip
check'
+ run_command_in_image 'pip check'
local res=$?
if [[ ${res} != "0" ]]; then
echo "${COLOR_RED_ERROR} ^^^ Some dependencies are conflicting. See
instructions below on how to deal with it. ${COLOR_RESET}"
echo
build_images::inform_about_pip_check "--production "
- # TODO(potiuk) - enable the comment once
https://github.com/apache/airflow/pull/12188 is merged
- # exit ${res}
+ exit ${res}
Review comment:
```suggestion
# exit ${res}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
