mschmo commented on a change in pull request #13072: URL: https://github.com/apache/airflow/pull/13072#discussion_r550312524
########## File path: airflow/providers/amazon/aws/hooks/glue_crawler.py ########## @@ -0,0 +1,159 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from time import sleep + +from cached_property import cached_property + +from airflow.exceptions import AirflowException +from airflow.providers.amazon.aws.hooks.base_aws import AwsBaseHook + + +class AwsGlueCrawlerHook(AwsBaseHook): + """ + Interacts with AWS Glue Crawler + :param poll_interval: Time (in seconds) to wait between two consecutive calls to check crawler status + :type poll_interval: int + :param config = Configurations for the AWS Glue crawler + :type config = dict + """ + + def __init__(self, poll_interval, *args, **kwargs): + self.poll_interval = poll_interval Review comment: IMO `poll_interval` shouldn't be a required argument for the hook. It makes sense as an argument for the sensor, but the hook I think should be a bit more vague in how it can interact with the Glue API. For instance `poll_interval` is irrelevant if I want to initialize a hook solely to get or create a crawler, and not poll for its status. I believe it may be better to pass `poll_interval` in as an argument to the `wait_for_crawler_completion` method, which is the only place it's used atm. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
