XD-DENG opened a new pull request #13449:
URL: https://github.com/apache/airflow/pull/13449
- Change-1: Use `getattr()` instead of __dict__ as __dict__ doesn't return
correct values for properties (sample code reproducing the issue is given
below). This was fixed for `dag` model, but was not fixed for `baseoperator`
model.
- Change-2: Avoid unnecessary condition check (the removed condition checks
are covered by `_comps`)
- Change-3: Use "==" rather than "is" to compare types (both work, but for
more consistent usage)
#### Sample Code Reproducing Issue in Change-1
```python
class C:
def __init__(self, elements):
self._elements = elements
@property
def elements(self):
return self._elements
def test(self):
print(self.__dict__.get("elements", None))
print(getattr(self, "elements", None))
a = C([1,2,3])
a.test()
```
Output:
```
None
[1, 2, 3]
```
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)**
for more information.
In case of fundamental code change, Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in
[UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
