ashb commented on a change in pull request #13278:
URL: https://github.com/apache/airflow/pull/13278#discussion_r551406309



##########
File path: airflow/utils/types.py
##########
@@ -24,6 +24,9 @@ class DagRunType(str, enum.Enum):
     SCHEDULED = "scheduled"
     MANUAL = "manual"
 
+    def __str__(self) -> str:  # pylint: disable=invalid-str-returned

Review comment:
       On current master
   
   ```
   In [19]: from  airflow.utils.types import DagRunType                         
                                                         
   
   In [20]: f'{DagRunType.SCHEDULED}__a'                                        
                                                         
   Out[20]: 'scheduled__a'
   ```
   
   Since it inherits from str I don't think we need this method.
   
   (This PR has gone through a number of iterations, firstly removing the `str` 
subclassing, then adding it back etc, so I'm not 100% sure on where it's at.)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to