feng-tao commented on issue #4974: [AIRFLOW-4057] Fix bug in stat name validation URL: https://github.com/apache/airflow/pull/4974#issuecomment-476414687 @astahlman , fyi, the py27 fails with the followings: ```====================================================================== 52) ERROR: test_increment_counter_with_valid_name (tests.test_stats.TestStats) ---------------------------------------------------------------------- Traceback (most recent call last): tests/test_stats.py line 33 in test_increment_counter_with_valid_name self.stats.incr('test_stats_run') airflow/stats.py line 83 in wrapper stat_name = handle_stat_name_func(stat) TypeError: unbound method stat_name_dummy_handler() must be called with AirflowTestPlugin instance as first argument (got str instance instead) ====================================================================== 53) ERROR: test_stat_name_must_be_a_string (tests.test_stats.TestStats) ---------------------------------------------------------------------- Traceback (most recent call last): tests/test_stats.py line 37 in test_stat_name_must_be_a_string self.stats.incr(list()) airflow/stats.py line 83 in wrapper stat_name = handle_stat_name_func(stat) TypeError: unbound method stat_name_dummy_handler() must be called with AirflowTestPlugin instance as first argument (got list instance instead) ====================================================================== 54) ERROR: test_stat_name_must_not_exceed_max_length (tests.test_stats.TestStats) ---------------------------------------------------------------------- Traceback (most recent call last): tests/test_stats.py line 41 in test_stat_name_must_not_exceed_max_length self.stats.incr('X' * 300) airflow/stats.py line 83 in wrapper stat_name = handle_stat_name_func(stat) TypeError: unbound method stat_name_dummy_handler() must be called with AirflowTestPlugin instance as first argument (got str instance instead) ====================================================================== 55) ERROR: test_stat_name_must_only_include_whitelisted_characters (tests.test_stats.TestStats) ---------------------------------------------------------------------- Traceback (most recent call last): tests/test_stats.py line 45 in test_stat_name_must_only_include_whitelisted_characters self.stats.incr('test/$tats') airflow/stats.py line 83 in wrapper stat_name = handle_stat_name_func(stat) TypeError: unbound method stat_name_dummy_handler() must be called with AirflowTestPlugin instance as first argument (got str instance instead)```
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
