madison-ookla commented on a change in pull request #13392:
URL: https://github.com/apache/airflow/pull/13392#discussion_r551520668
##########
File path: airflow/upgrade/checker.py
##########
@@ -41,6 +41,15 @@ def check_upgrade(formatter, rules):
return all_rule_statuses
+def list_checks():
+ print()
+ print("Upgrade Checks:")
+ for rule in ALL_RULES:
Review comment:
It looks like the current assumption is that the version check should
run first (based off of the fact that these files are run in alphabetical order
and it's currently prefixed with `aaa_`:
https://github.com/apache/airflow/tree/v1-10-stable/airflow/upgrade/rules).
This will alter that order, and I think it might not be best to change the name
of the version check class as people may already be ignoring it/using it
elsewhere. I'm open to changing this if those concerns aren't as widely shared
:)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
