houqp commented on pull request #13278:
URL: https://github.com/apache/airflow/pull/13278#issuecomment-755602084


   > Ohhh, this is only a problem for one of the mysql drivers -mysqldb. The 
"default" that you get via apache-airflow[mysql] is mysqlclient which doesn't 
have this problem.
   
   This is happening to mysqlclient. But I haven't tested it with pymysql, 
which might or might not have this problem.
   
   > While this seems a reasonable approach (that's how I would do it), I do 
not think we provide any tooling nor instructions for it (like a tool to tell 
"OK all tasks completed, you can now safely migrate Airflow").
   
   That's right, we perform all schema upgrade online without shutting down 
airflow components. The only time we did stop the world migration was for 2.0 
upgrade.
   
   I am a little bit hesitant to add this fix up into scheduler startup code if 
we can get away without it.
   
   Based on the discussion so far, would it be accessible to add a note in the 
release note to ask users to run a fix up command after new code has been 
deployed? If so we can add a fix up command in airflow cli do that.
   
   Alternatively, we can go all in on native enum column type in postgres and 
mysql, which means we will be able to manage the fix up with alembic.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to