houqp commented on a change in pull request #13299:
URL: https://github.com/apache/airflow/pull/13299#discussion_r552939598
##########
File path: airflow/kubernetes/pod_generator.py
##########
@@ -370,6 +368,10 @@ def construct_pod( # pylint: disable=too-many-arguments
except Exception: # pylint: disable=W0703
image = kube_image
+ task_id = make_safe_label_value(task_id)
+ dag_id = make_safe_label_value(dag_id)
+ scheduler_job_id = make_safe_label_value(scheduler_job_id)
Review comment:
i do think it would be more consistent if we use int everywhere since
that's the type we get from db. but i haven't had the time to check if it's
been converted to str already somewhere upstream.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
