turbaszek commented on a change in pull request #13256:
URL: https://github.com/apache/airflow/pull/13256#discussion_r554045869
##########
File path: airflow/providers/google/cloud/operators/dataproc.py
##########
@@ -613,18 +609,18 @@ def execute(self, context) -> dict:
# Check if cluster is not in ERROR state
self._handle_error_state(hook, cluster)
- if cluster.status.state == cluster.status.CREATING:
+ if cluster.status.state == cluster.status.State.CREATING:
# Wait for cluster to be be created
cluster = self._wait_for_cluster_in_creating_state(hook)
self._handle_error_state(hook, cluster)
- elif cluster.status.state == cluster.status.DELETING:
+ elif cluster.status.state == cluster.status.State.DELETING:
# Wait for cluster to be deleted
self._wait_for_cluster_in_deleting_state(hook)
# Create new cluster
cluster = self._create_cluster(hook)
self._handle_error_state(hook, cluster)
- return MessageToDict(cluster)
+ return Cluster.to_json(cluster)
Review comment:
Nice catch!
##########
File path: airflow/providers/google/cloud/hooks/dataproc.py
##########
@@ -26,18 +26,16 @@
from google.api_core.exceptions import ServerError
from google.api_core.retry import Retry
from google.cloud.dataproc_v1beta2 import ( # pylint:
disable=no-name-in-module
- ClusterControllerClient,
- JobControllerClient,
- WorkflowTemplateServiceClient,
-)
-from google.cloud.dataproc_v1beta2.types import ( # pylint:
disable=no-name-in-module
Cluster,
- Duration,
- FieldMask,
+ ClusterControllerClient,
Job,
+ JobControllerClient,
JobStatus,
WorkflowTemplate,
+ WorkflowTemplateServiceClient,
)
+from google.protobuf.duration_pb2 import Duration
+from google.protobuf.field_mask_pb2 import FieldMask
Review comment:
Fixed 🆗
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
