mik-laj edited a comment on pull request #12010:
URL: https://github.com/apache/airflow/pull/12010#issuecomment-757344368


   > I am not sure I have a clear idea about would you have in mind. Could you 
be a bit more precise?
   
   We run a set of integration tests for Kubernetes for each PR. To do it, we 
run a KIND cluster on Github Action, and in it, we deploy Airflow using the 
Helm Chart. After deployment, we perform a few simple operations, e.g. run DAG 
to check if everything works. After implementation, we perform a few simple 
operations, e.g. run DAG to check if everything works.  To be able to test the 
Helm Chart with more confidence, I want to work on system tests that deploy 
infrastructure with Terraform and then install Airflow with Helm Chart. And 
then it does some basic operations.
   
   Some changes would be useful in order for this change to be accepted. First 
of all, we should delete references to Google solutions, but the ability to 
configure your own annotations sounds interesting. 
   For example,  if you want to use Workflow Identity then you need to annotate 
Service Account, so we don't want to support just one annotation, but we've 
added generic support for any annotation.
   See: 
   https://github.com/apache/airflow/pull/11131
   https://github.com/apache/airflow/pull/11387
   
   Before this change was posted to the community, the change looked like this:
   ![Screenshot 2021-01-09 at 19 02 
30](https://user-images.githubusercontent.com/12058428/104105300-6313e480-52ad-11eb-9212-6eede90d1e44.png)
   It's not something we want to accept, so we had to rewrite it.
   
   Additional facilities, if needed, can be deployed independently of Helm 
Chart.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to