XD-DENG commented on pull request #12010:
URL: https://github.com/apache/airflow/pull/12010#issuecomment-757363694


   Hi everyone, sorry I just saw this change, and I have a few questions:
   - in `values.yaml`, shouldn't this new item `brokerUrl` be added under 
`redis` rather than `data`? `data` is for database based on what's under it 
earlier (metadatabase and broker backend db, both are actually database).
   - the name `brokerUrl` itself is misleading, because broker can be something 
else, like RabbitMQ.
   
   
   Please let me know your thoughts @mik-laj @kaxil @potiuk . In my view, some 
follow-up changes will be needed. Please let me know if I have misunderstood 
anything. Cheers.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to