kaxil commented on a change in pull request #13488:
URL: https://github.com/apache/airflow/pull/13488#discussion_r554234690
##########
File path: scripts/in_container/run_prepare_provider_packages.sh
##########
@@ -196,9 +197,9 @@ function rename_packages_if_needed() {
fi
fi
- popd
+ popd >/dev/null
echo
- echo "Airflow packages are in dist folder "
+ echo "${COLOR_GREEN_OK} Airflow packages are prepared in dist
folder${COLOR_RESET}"
Review comment:
```suggestion
echo "${COLOR_GREEN}OK Airflow packages are prepared in dist
folder${COLOR_RESET}"
```
##########
File path: scripts/in_container/run_prepare_provider_packages.sh
##########
@@ -196,9 +197,9 @@ function rename_packages_if_needed() {
fi
fi
- popd
+ popd >/dev/null
echo
- echo "Airflow packages are in dist folder "
+ echo "${COLOR_GREEN_OK} Airflow packages are prepared in dist
folder${COLOR_RESET}"
Review comment:
Apologies, this is needed coz I just merged
https://github.com/apache/airflow/commit/9d6c7487dd03a42d1b6a1f19fae0c9a746139dbe
##########
File path: scripts/in_container/run_prepare_provider_packages.sh
##########
@@ -167,7 +167,8 @@ function build_provider_packages() {
cat "${LOG_FILE}"
exit "${RES}"
fi
- echo " Prepared ${PACKAGE_TYPE} package ${PROVIDER_PACKAGE} format
${PACKAGE_FORMAT}"
+ echo
"==================================================================================="
+ echo "${COLOR_GREEN_OK} Prepared ${PACKAGE_TYPE} package
${PROVIDER_PACKAGE} format ${PACKAGE_FORMAT}${COLOR_RESET}"
Review comment:
```suggestion
echo "${COLOR_GREEN}OK Prepared ${PACKAGE_TYPE} package
${PROVIDER_PACKAGE} format ${PACKAGE_FORMAT}${COLOR_RESET}"
```
##########
File path: scripts/in_container/run_prepare_provider_packages.sh
##########
@@ -167,7 +167,8 @@ function build_provider_packages() {
cat "${LOG_FILE}"
exit "${RES}"
fi
- echo " Prepared ${PACKAGE_TYPE} package ${PROVIDER_PACKAGE} format
${PACKAGE_FORMAT}"
+ echo
"==================================================================================="
+ echo "${COLOR_GREEN_OK} Prepared ${PACKAGE_TYPE} package
${PROVIDER_PACKAGE} format ${PACKAGE_FORMAT}${COLOR_RESET}"
Review comment:
Feel free to discard review after making these changes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
