turbaszek commented on a change in pull request #13536:
URL: https://github.com/apache/airflow/pull/13536#discussion_r554948512



##########
File path: tests/providers/docker/operators/test_docker.py
##########
@@ -244,7 +244,7 @@ def test_execute_xcom_behavior(self):
         xcom_push_result = xcom_push_operator.execute(None)
         no_xcom_push_result = no_xcom_push_operator.execute(None)
 
-        self.assertEqual(xcom_push_result, b'container log')
+        self.assertEqual(xcom_push_result, 'container log')

Review comment:
       I know, but changing this type is a breaking change. Assuming users used 
pickle as XCom they were able to pickle that, and then they possibily used 
`decoded` method which is unavailable for `str` type, so something like this:
   ```py
   the_output_from_xcom.decode("utf-8")
   ```
   won't work, am I right?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to