kaxil commented on a change in pull request #13563:
URL: https://github.com/apache/airflow/pull/13563#discussion_r555778217
##########
File path: airflow/cli/commands/kubernetes_command.py
##########
@@ -90,7 +90,7 @@ def cleanup_pods(args):
print('Loading Kubernetes configuration')
kube_client = get_kube_client()
print(f'Listing pods in namespace {namespace}')
- continue_token = None
+ continue_token = ''
while True: # pylint: disable=too-many-nested-blocks
pod_list = kube_client.list_namespaced_pod(namespace=namespace,
limit=500, _continue=continue_token)
for pod in pod_list.items:
Review comment:
Btw I have no problem with the current suggestion too of using an empty
string (`''`) , but want to make sure it works with 11.0 and 12.0 (we will
support 12.0 soon -- or at least in near future)
Personally, I would not set it for the first iteration but it does not make
a difference
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
