[GitHub] [airflow] soltanianalytics edited a comment on pull request #13640: Fixes problems with extras for custom connection types

Tue, 12 Jan 2021 15:04:17 -0800 


soltanianalytics edited a comment on pull request #13640:
URL: https://github.com/apache/airflow/pull/13640#issuecomment-759091999


   Could this be the issue?
   
   shouldn't it be `form.data.extra` instead of `form.extra.data`?
   
https://github.com/apache/airflow/blob/77f0ca5682017ef50dbf90f84df75362e5da5c8b/airflow/www/views.py#L2904
   
   
![image](https://user-images.githubusercontent.com/46958547/104384840-72f02a80-5532-11eb-834b-2759118ddb22.png)
   
   
   Edit:
   
   On the one hand, that seems to be how it is used in the next function below:
   
![image](https://user-images.githubusercontent.com/46958547/104385037-cb272c80-5532-11eb-8a6b-c03f5b1da6f6.png)
   
   On the other hand, you didn't change that part and it did work for `jdbc`
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to