potiuk commented on a change in pull request #13640:
URL: https://github.com/apache/airflow/pull/13640#discussion_r556177228
##########
File path: airflow/www/views.py
##########
@@ -2894,9 +2894,13 @@ def action_muldelete(self, items):
def process_form(self, form, is_created):
"""Process form data."""
- formdata = form.data
- if formdata['conn_type'] in ['jdbc', 'google_cloud_platform', 'grpc',
'yandexcloud', 'kubernetes']:
- extra = {key: formdata[key] for key in self.extra_fields if key in
formdata}
+ conn_type = form.data['conn_type']
+ extra = {
+ key: form.data[key]
+ for key in self.extra_fields
+ if key in form.data and key.startswith(f"extra__{conn_type}__")
Review comment:
Nope. That looks ok. Keys in form.data will be there is there are some
fields added and you entered some value there (or it will be pre-fiiled) . The
value will only be prefilled if the extra is already in the the connection and
is not empty. The code looks good.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
