potiuk commented on a change in pull request #4936: [AIRFLOW-4115]
Multi-staging Aiflow Docker image [Step 1/3]
URL: https://github.com/apache/airflow/pull/4936#discussion_r269466926
##########
File path: setup.py
##########
@@ -252,7 +253,7 @@ def write_version(filename=os.path.join(*['airflow',
'qds-sdk>=1.9.6',
'rednose',
'requests_mock',
- 'flake8>=3.6.0',
+ 'virtualenv',
Review comment:
Yeah. But venv3 is only available on python3 and not widely used (and has no
"virtualenv" script equivalent). The PythonVirtualenvOperator uses
"virtualenv" command to start virtualenv now - so we need to install it also
for python3. Maybe when we drop Python 2 (finally!) we can switch the operator
to venv and get rid of virtualenv :).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
