potiuk commented on a change in pull request #13660:
URL: https://github.com/apache/airflow/pull/13660#discussion_r557041375



##########
File path: docs/apache-airflow/start/docker-compose.yaml
##########
@@ -0,0 +1,101 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+---
+version: '3'
+x-airflow-common:

Review comment:
       This docker-compose does not work with docker-compose version 1.25.3 
which is default version on Linux 'debian buster' LTS. You need to manually 
instal 1.27.4 which supports anchors.
   
   When you try to ruin in the 1.25.3 you get this message that does not 
explain much:
   
   ```
   ERROR: The Compose file './docker-compose.yaml' is invalid because:
   Invalid top-level property "x-airflow-common". Valid top-level sections for 
this Compose file are: version, services, networks, volumes, and extensions 
starting with "x-".
   
   You might be seeing this error because you're using the wrong Compose file 
version. Either specify a supported version (e.g "2.2" or "3.3") and place your 
service definitions under the `services` key, or omit the `version` key and 
place your service definitions at the root of the file to use version 1.
   For more on the Compose file format versions, see 
https://docs.docker.com/compose/compose-file/
   services.airflow-scheduler.depends_on contains an invalid type, it should be 
an array
   services.airflow-webserver.depends_on contains an invalid type, it should be 
an array
   services.airflow-worker.depends_on contains an invalid type, it should be an 
array
   services.flower.depends_on contains an invalid type, it should be an array
   ```
   
   It would be great if we find a way to provide better message explaining that 
minimum supported version is X (wihich one is it ) and directing people to 
installation/upgrade instructions. At the very least - if we cannot do it we 
should clearly state it in the docs that this is prerequisite and explain that 
this message means they have to upgrade docker-compose.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to