potiuk commented on pull request #12505:
URL: https://github.com/apache/airflow/pull/12505#issuecomment-761890384


   > It's like having a MySqlINNODBOperator and a MySqlMyISAMOperator; either 
way you're just executing sql.
   
   If this is close to 100% of code - that's cool.
   
   How about backwards compatibility then ? We have the rule that we do not 
remove stuff (semver versioning for providers is clear about it). 
   
   We have an existing S3ToSnnowflake operator with s3_keys as parameter. 
   
   From what I see you propose is to have AnyStorageToSnowflake operator. 
   
   How about adding (as next step) such an operator with keeping the 
S3ToSnowflake as a proxy to this one (converting s3_keys to 'storage_keys' - 
but throwing depracation warning). Then you could  system-testing the other 
cases (Google/Azure) and add the general operator next to the existing one. The 
'extra' code will be just mapping init parameters. and in 2.0.0 version of 
snowflake provider we could drop it.
   
   How about that?
   
   There is a big value in keeping backwards-compatibility. We've done that for 
some 500 operators when we moved them from "contrib" to "providers". This is 
not really a 'waste' - this is thinking about your users.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to