grepthat commented on pull request #13299: URL: https://github.com/apache/airflow/pull/13299#issuecomment-762058706
@houqp In `adopt_launched_task` a pod id is reconstructed from the 'dag_id' and 'task_id' labels of the pod (that were made safe previously) and then checked if that reconstructed pod id is in the `pod_ids` list. https://github.com/apache/airflow/blob/1ec63123c4310f2343dcd7c349f90063c401c0d9/airflow/executors/kubernetes_executor.py#L628-L631 The `pod_ids` list passed to `adopt_launched_task` is a list of pod ids reconstructed from the **raw** 'dag_id' and 'task_id' (without making the IDs safe beforehand) https://github.com/apache/airflow/blob/1ec63123c4310f2343dcd7c349f90063c401c0d9/airflow/executors/kubernetes_executor.py#L605-L607 Will this not yield problems? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
