[
https://issues.apache.org/jira/browse/AIRFLOW-4170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16803503#comment-16803503
]
ASF GitHub Bot commented on AIRFLOW-4170:
-----------------------------------------
cixuuz commented on pull request #4991: [AIRFLOW-4170] Try serialize value by
JSON when importing Variables
URL: https://github.com/apache/airflow/pull/4991
Make sure you have checked _all_ steps below.
### Jira
- [ ] My PR addresses the following [Airflow
4170](https://issues.apache.org/jira/browse/AIRFLOW-4170) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-XXX
- In case you are fixing a typo in the documentation you can prepend your
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
- In case you are proposing a fundamental code change, you need to create
an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
- In case you are adding a dependency, check if the license complies with
the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
### Description
- [ ] Here are some details about my PR, including screenshots of any UI
changes:
When importing variables from a file, it serializes value in JSON only when
value is dict. But value may be list or other valid JSON type. For example, the
value is a list of string, ```["example"]```. First, export values into a file.
In file, it looks like ```{"key": ["example"]}```, and then import the file to
variables, it will be stored as ```['example']```. You may get a
JSONdecodeerror when you try to get the value because it's not double quote.
Thus, instead of judging by type, we could blindly try dump variables as
JSON.
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [ ] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes
how to use it.
- When adding new operators/hooks/sensors, the autoclass documentation
generation needs to be added.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
### Code Quality
- [ ] Passes `flake8`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Set variable using json in CLI
> ------------------------------
>
> Key: AIRFLOW-4170
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4170
> Project: Apache Airflow
> Issue Type: Improvement
> Components: cli
> Reporter: Chen Tong
> Priority: Major
>
> When importing variables, it serializes value in JSON way only when value is
> dict. But value may be list or other types, which is also valid JSON type.
> {code:java}
> if isinstance(v, dict):
> Variable.set(k, v, serialize_json=True)
> else:
> Variable.set(k, v)
> {code}
> One use case is first export values into a file and then import the file to
> variables. Since the export is always a JSON file. Import may be invalid when
> the value type is not dict.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
