gardnerdev commented on a change in pull request #13735:
URL: https://github.com/apache/airflow/pull/13735#discussion_r561824853
##########
File path: chart/values.yaml
##########
@@ -391,6 +392,9 @@ scheduler:
# Annotations to add to scheduler kubernetes service account.
serviceAccountAnnotations: {}
+ # Launch additional containers into scheduler.
+ extraContainers: []
+
# Mount additional volumes into scheduler.
extraVolumes: []
Review comment:
How to mount scheduler dags folder to s3-sync? Any example?
##########
File path: chart/README.md
##########
@@ -366,6 +366,17 @@ helm install airflow . \
--set data.brokerUrl=redis://redis-user:password@redis-host:6379/0
```
+## Using additional containers
+
+If you are using your own sidecar container, you can add it through the
`extraContainers` value. You can define different containers for scheduler,
webserver and worker pods. For example, a sidecar that syncs DAGs from object
storage.
+
+```bash
Review comment:
@Swalloow could you put in docs or here how you implemented sindecar
container pattern? I mean mounting volumes example
##########
File path: chart/values.yaml
##########
@@ -391,6 +392,9 @@ scheduler:
# Annotations to add to scheduler kubernetes service account.
serviceAccountAnnotations: {}
+ # Launch additional containers into scheduler.
+ extraContainers: []
+
# Mount additional volumes into scheduler.
extraVolumes: []
Review comment:
Thanks, I am using [ https://github.com/houqp/objinsync ](
https://github.com/houqp/objinsync ) but thanks to you I was able to configure
it!
##########
File path: chart/values.yaml
##########
@@ -391,6 +392,9 @@ scheduler:
# Annotations to add to scheduler kubernetes service account.
serviceAccountAnnotations: {}
+ # Launch additional containers into scheduler.
+ extraContainers: []
+
# Mount additional volumes into scheduler.
extraVolumes: []
Review comment:
I am using [ https://github.com/houqp/objinsync ](
https://github.com/houqp/objinsync ) but thanks to you I was able to configure
it!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
