mik-laj commented on a change in pull request #13745: URL: https://github.com/apache/airflow/pull/13745#discussion_r563221653
########## File path: airflow/providers/slack/ADDITIONAL_INFO.md ########## @@ -0,0 +1,33 @@ +<!-- + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. + --> + +# Migration Guide + +## 3.0.0 + +Reference: https://slack.dev/python-slack-sdk/v3-migration/index.html#from-slackclient-2-x + +### Use ``AsyncWebClient`` for async options + +With v3 upgrade, `WebClient` no longer has `run_async` and `aiohttp` specific options. If you still need the option or other `aiohttp` specific options, use `LegacyWebClient` (slackclient v2 compatible) or `AsyncWebClient` + + +### Include ``aiohttp`` in requirements + +`aiohttp` is no longer automatically resolved with `slack_sdk`(earlier `slackclient`). So, if working with `AsyncWebClient`, `AsyncWebhookClient`, and `LegacyWebClient`, it needs separate installation. Review comment: ```suggestion ## 2.0.0 We updated the support for `sentry_sdk` from ``>=2.0.0,<3.0.0`` to ``>=3.0.0,<4.0.0``. In most cases, this doesn't mean any breaking changes to the DAG files, but if you used this library directly then you have to make the changes. For details, see the `Migration Guide <https://slack.dev/python-slack-sdk/v3-migration/index.html#from-slackclient-2-x>`__ for Python Slack SDK. ``` We should only focus on the changes that affect our project. In this case, there aren't too many breaking changes except that sometimes users may have conflicting dependencies. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
