mik-laj commented on pull request #13660:
URL: https://github.com/apache/airflow/pull/13660#issuecomment-766312443


   > I am wondering if we should use a .env file to populate some 
docker-compose values (which is passed to docker-compose automatically if in 
same dir).
   
   I added a few parameters to the docker-compose file, but I was very careful 
not to complicate this file.
   I only added these parameters in a few cases:
   - If it was necessary to ensure compatibility with Linux, (``AIRFLOW_UID``, 
``AIRFLOW_GID``),
   -  if I thought it could be a really frequently changed option 
(``AIRFLOW_IMAGE_NAME``),
   - if it is a good example of using parameterization 
(_AIRFLOW_WWW_USER_USERNAME, _AIRFLOW_WWW_USER_PASSWORD)
   
   Each variable has a default value defined so the .env file is optional. I 
also didn't define variables for internal details, e.g. database passwords, 
because Docker provides network isolation.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to