jgao54 commented on a change in pull request #4975: AIRFLOW-4149 add extra gRPC
fields to connections forms
URL: https://github.com/apache/airflow/pull/4975#discussion_r270208757
##########
File path: airflow/www/forms.py
##########
@@ -138,3 +138,12 @@ class ConnectionForm(DynamicForm):
extra__google_cloud_platform__scope = StringField(
lazy_gettext('Scopes (comma separated)'),
widget=BS3TextFieldWidget())
+ extra__grpc__auth_type = StringField(
+ lazy_gettext('gRPC Auth Type'),
+ widget=BS3TextFieldWidget())
+ extra__grpc__credential_pem_file = StringField(
+ lazy_gettext('Credential pem file Path'),
Review comment:
for consistency, could you rename this to `Keyfile Path`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services