mik-laj commented on a change in pull request #4992: [AIRFLOW-4172] Fix changes
for driver class path option in Spark Subm…
URL: https://github.com/apache/airflow/pull/4992#discussion_r270278567
##########
File path: airflow/contrib/hooks/spark_submit_hook.py
##########
@@ -250,8 +250,8 @@ def _build_spark_submit_command(self, application):
connection_cmd += ["--py-files", self._py_files]
if self._archives:
connection_cmd += ["--archives", self._archives]
- if self._driver_classpath:
- connection_cmd += ["--driver-classpath", self._driver_classpath]
+ if self._driver_class_path:
+ connection_cmd += ["--driver-class-path", self._driver_class_path]
Review comment:
Can you add backward compatibility and a note in the UPDATING.md file? In
future versions, we will drop support for the old parameter name.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
