ashb commented on a change in pull request #4996: [AIRFLOW-4184] Add an athena
helper to insert into table
URL: https://github.com/apache/airflow/pull/4996#discussion_r270354521
##########
File path: airflow/contrib/hooks/aws_athena_hook.py
##########
@@ -148,3 +156,105 @@ def stop_query(self, query_execution_id):
:return: dict
"""
return
self.conn.stop_query_execution(QueryExecutionId=query_execution_id)
+
+
+class AWSAthenaHelpers(AWSAthenaHook):
Review comment:
This class name doesn't follow any of Airflow's conventions.
This feels like an operator, not a hook class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
