dstandish edited a comment on pull request #6850: URL: https://github.com/apache/airflow/pull/6850#issuecomment-768548513
@ldacey let me add... Just shepherding something through the merge process is meaningful and valuable contribution in itself and this method would probably be a helpful addition. But there also remains meaningful creative work to be done. For example, we ought to think through whether and how to make it so `MsSqlOperator` can optionally use turbodbc. Right now, it will use odbc hook if conn type is `odbc` and original `MsSqlHook` otherwise. *(That is, if conn uri is `odbc://blah...` MsSqlOperator will use OdbcHook)*. It's possible you could make it so if conn type is `turbodbc` then it uses turbodbc connection. Or perhaps you might decide it makes more sense to contribute a turbodbc hook, which could be a thin subclass of odbc hook, changing only get_conn. Or, maybe we just add that single method and people can use it in their own operators, like you do now 🤷♂️ I never got around to thinking through these decisions, which is partly i never made a pr for it. Additionally there is the need to address documentation. So, you can definitely contribute support for turbodbc without feeling in any way that you appropriated anything. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
