saurabh3091 commented on a change in pull request #4992: [AIRFLOW-4172] Fix 
changes for driver class path option in Spark Subm…
URL: https://github.com/apache/airflow/pull/4992#discussion_r270360584
 
 

 ##########
 File path: airflow/contrib/hooks/spark_submit_hook.py
 ##########
 @@ -250,8 +250,8 @@ def _build_spark_submit_command(self, application):
             connection_cmd += ["--py-files", self._py_files]
         if self._archives:
             connection_cmd += ["--archives", self._archives]
-        if self._driver_classpath:
-            connection_cmd += ["--driver-classpath", self._driver_classpath]
+        if self._driver_class_path:
+            connection_cmd += ["--driver-class-path", self._driver_class_path]
 
 Review comment:
   @mik-laj Backward compatilibility is applicable to some thing that was 
working before but this option never worked, this seems to be a typo and it is 
also not a mandatory parameter to pass in the job so nobody cared till now.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to