potiuk commented on pull request #13984:
URL: https://github.com/apache/airflow/pull/13984#issuecomment-770244768


   > @potiuk, I'd say it's a separate issue. The scope of this fix is just to 
make sure that when the DAG source code is read from a zipped package, it is 
returned in exactly the same way as for a non-zipped file. In both cases it 
uses the Python's default encoding and with this fix the outcome of calling 
`open_maybe_zipped` is identical for both cases.
   > I'd suggest a separate issue is created and tracked for what you are 
describing. In the meantime, this fix unblocks all the folks who want to use 
zipped packages and have `store_dag_code` option enabled.
   
   Happy to hear what others think, but since testing is about the same piece 
of code and potentially resulting in errors in the same plce. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to