mik-laj commented on a change in pull request #4823: [AIRFLOW-3999] Remove all
inline style
URL: https://github.com/apache/airflow/pull/4823#discussion_r270422423
##########
File path: airflow/www/templates/airflow/graph.html
##########
@@ -43,37 +51,36 @@
<input name="_csrf_token" type="hidden" value="{{ csrf_token() }}">
<input type="submit" value="Go" class="btn btn-default">
</form>
- <div class="input-group" style="float: right;">
+ <div class="input-group pull-right">
<input type="text" id="searchbox" class="form-control" placeholder="Search
for...">
</div>
- <div style="clear: both;"></div>
</div>
<hr/>
-<div>
- {% for op in operators %}
- <div class="legend_item"
- style="border-width:1px;float:left;background:{{ op.ui_color
}};color:{{ op.ui_fgcolor }};">
- {{ op.__name__ }}
+<div class="clearfix">
+ <div class="legend legend--pills pull-left">
+ {% for op in operators %}
+ <div class="legend__item"
+ data-operator-name="{{ op.__name__ }}">
+ {{ op.__name__ }}
+ </div>
+ {% endfor %}
</div>
- {% endfor %}
-
- <div>
- <div class="legend_item state" style="border-color:white;">no_status</div>
- <div class="legend_item state" style="border-color:grey;">queued</div>
- <div class="legend_item state"
style="border-color:gold;">up_for_retry</div>
- <div class="legend_item state"
style="border-color:turquoise;">up_for_reschedule</div>
- <div class="legend_item state" style="border-color:pink;">skipped</div>
- <div class="legend_item state" style="border-color:red;">failed</div>
- <div class="legend_item state" style="border-color:lime;">running</div>
- <div class="legend_item state" style="border-color:green;">success</div>
+ <div class="legend legend--pills legend--state pull-right">
Review comment:
It is also used in the CSS code.
https://github.com/apache/airflow/pull/4823/files#diff-eddd096d3961f002a677cf7d45bd1657R60
https://github.com/apache/airflow/pull/4823/files#diff-eddd096d3961f002a677cf7d45bd1657R27
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
