jhtimmins opened a new pull request #14042:
URL: https://github.com/apache/airflow/pull/14042


   Fixes the issue wherein regardless of what role anonymous users are assigned 
(via the `AUTH_ROLE_PUBLIC` env var), they can't see any DAGs.
   
   Current behavior causes:
   Anonymous users are handled as a special case by Airflow's DAG-related 
security methods (`.has_access()` and `.get_accessible_dags()`). Rather than 
checking the `AUTH_ROLE_PUBLIC` value to check for role permissions, the 
methods reject access to view or edit any DAGs.
   
   Changes in this PR:
   Rather than hardcoding permission rules inside the security methods, this 
change checks the `AUTH_ROLE_PUBLIC` value and gives anonymous users all 
permissions linked to the designated role. 
   
   **This places security in the hands of the Airflow users. If the value is 
set to `Admin`, anonymous users will have full admin functionality.**
   
   This also changes how the `Public` role is created. Currently, the `Public` 
role is created automatically by Flask App Builder. This PR explicitly declares 
`Public` as a default role with no permissions in `security.py`. This change 
makes it easier to test.
   
   closes: #13340 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to