leahecole commented on a change in pull request #14033:
URL: https://github.com/apache/airflow/pull/14033#discussion_r569945414
##########
File path: airflow/providers/google/cloud/example_dags/example_dlp.py
##########
@@ -177,3 +178,31 @@
)
# [END howto_operator_dlp_delete_job_trigger]
create_trigger >> update_trigger >> delete_trigger
+
+DEIDENTIFY_CONFIG = {
Review comment:
Would it be worth also including the config in the documentation right
before the example? Given the fact that this config isn't just a string, I
think it might be worth showing
##########
File path: docs/apache-airflow-providers-google/sensors/cloud/gcs.rst
##########
@@ -0,0 +1,75 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ .. http://www.apache.org/licenses/LICENSE-2.0
+
+ .. Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+
+
+
+Google Cloud Storage Sensors
+============================
+
+Cloud Storage allows world-wide storage and retrieval of any amount of data at
any time.
+You can use Cloud Storage for a range of scenarios including serving website
content,
+storing data for archival and disaster recovery, or distributing large data
objects to users via direct download.
+
+.. contents::
+ :depth: 1
+ :local:
+
+Prerequisite Tasks
+^^^^^^^^^^^^^^^^^^
+
+.. include::/sensors/_partials/prerequisite_tasks.rst
+
+.. _howto/sensor:GCSObjectExistenceSensor:
+
+GCSObjectExistenceSensor
+------------------------
+
+Use the
:class:`~airflow.providers.google.cloud.sensors.gcs.GCSObjectExistenceSensor`
to wait (poll) for the existence of a file in Google Cloud Storage.
+
+.. exampleinclude::
/../../airflow/providers/google/cloud/example_dags/example_gcs_sensors.py
+ :language: python
+ :dedent: 4
+ :start-after: [START howto_sensor_object_exists_task]
+ :end-before: [END howto_sensor_object_exists_task]
+
+.. _howto/sensor:GCSObjectsWtihPrefixExistenceSensor:
+
+GCSObjectsWtihPrefixExistenceSensor
Review comment:
I just looked - is this a typo in the sensor? I did look at the source
code and thsi at least matches that code, but if this is a typo we should
definitely fix it 😬 Or does Wtih stand for something?
##########
File path: docs/apache-airflow-providers-google/sensors/cloud/gcs.rst
##########
@@ -0,0 +1,75 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ .. http://www.apache.org/licenses/LICENSE-2.0
+
+ .. Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+
+
+
+Google Cloud Storage Sensors
+============================
+
+Cloud Storage allows world-wide storage and retrieval of any amount of data at
any time.
+You can use Cloud Storage for a range of scenarios including serving website
content,
+storing data for archival and disaster recovery, or distributing large data
objects to users via direct download.
+
+.. contents::
+ :depth: 1
+ :local:
+
+Prerequisite Tasks
Review comment:
Oops I hadn't seen the other prerequisites file - I think it's not
rendering properly
##########
File path: docs/apache-airflow-providers-google/sensors/cloud/gcs.rst
##########
@@ -0,0 +1,75 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ .. http://www.apache.org/licenses/LICENSE-2.0
+
+ .. Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+
+
+
+Google Cloud Storage Sensors
+============================
+
+Cloud Storage allows world-wide storage and retrieval of any amount of data at
any time.
+You can use Cloud Storage for a range of scenarios including serving website
content,
+storing data for archival and disaster recovery, or distributing large data
objects to users via direct download.
+
+.. contents::
+ :depth: 1
+ :local:
+
+Prerequisite Tasks
Review comment:
The two headings you add with the two example sensors show up under
Prerequisite tasks - is that where you want them? Or is it that prerequisite
tasks is empty and it's rendering incorrectly?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
