dstandish commented on a change in pull request #13796:
URL: https://github.com/apache/airflow/pull/13796#discussion_r570702241
##########
File path: airflow/providers/amazon/aws/transfers/s3_to_ftp.py
##########
@@ -27,15 +27,14 @@
class S3ToFTPOperator(BaseOperator):
"""
This operator enables the transferring of files from S3 to a FTP server.
-
:param ftp_conn_id: The ftp connection id. The name or identifier for
establishing a connection to the FTP server.
:type ftp_conn_id: str
- :param ftp_path: The ftp remote path. This is the specified file path for
- uploading file to the FTP server.
+ :param ftp_path: The ftp remote path in where the file will be stored.
+ The desired file name must be specified here.
Review comment:
```suggestion
:param ftp_path: The ftp remote path where the file will be stored,
inclusive of filename.
```
##########
File path: airflow/providers/amazon/aws/transfers/s3_to_ftp.py
##########
@@ -27,15 +27,14 @@
class S3ToFTPOperator(BaseOperator):
"""
This operator enables the transferring of files from S3 to a FTP server.
-
:param ftp_conn_id: The ftp connection id. The name or identifier for
establishing a connection to the FTP server.
:type ftp_conn_id: str
- :param ftp_path: The ftp remote path. This is the specified file path for
- uploading file to the FTP server.
+ :param ftp_path: The ftp remote path in where the file will be stored.
+ The desired file name must be specified here.
:type ftp_path: str
:param s3_conn_id: The s3 connection id. The name or identifier for
- establishing a connection to S3.
+ establish a connection to S3.
Review comment:
was correct before
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
