[GitHub] [airflow] mik-laj commented on a change in pull request #13999: Simplify Kerberos network setup

[GitBox]

mik-laj commented on a change in pull request #13999:
URL: https://github.com/apache/airflow/pull/13999#discussion_r570286738



##########
File path: scripts/ci/docker-compose/integration-kerberos.yml
##########
@@ -79,4 +79,11 @@ volumes:
 
 networks:
   example.com:
-    external: true
+    name: example.com
+    driver: bridge
+    attachable: true

Review comment:
       What version of docker-compose do we have installed?  Docker Compose 
1.28.2 is preinstalled on the hosted runner. 
https://github.com/actions/virtual-environments/blob/main/images/linux/Ubuntu2004-README.md

##########
File path: scripts/ci/docker-compose/integration-kerberos.yml
##########
@@ -79,4 +79,11 @@ volumes:
 
 networks:
   example.com:
-    external: true
+    name: example.com
+    driver: bridge
+    attachable: true

Review comment:
       Installation script: 
https://github.com/actions/virtual-environments/blob/main/images/linux/scripts/installers/docker-compose.sh

##########
File path: scripts/ci/docker-compose/integration-kerberos.yml
##########
@@ -79,4 +79,11 @@ volumes:
 
 networks:
   example.com:
-    external: true
+    name: example.com
+    driver: bridge
+    attachable: true

Review comment:
       I also do not know if we need this flag.  I checked the network 
configuration that is created by docker-compose using the ``docker inspect 
example.com`` command and entered the identical configuration in the 
`docker-compose.yaml` file.  Kerberos is very sensitive to changes in the 
network, so I didn't want to break anything.
   
   To check the available options in the specification, I chose these 
specifications in the IDE.
   <img width="469" alt="Screenshot 2021-02-04 at 16 47 05" 
src="https://user-images.githubusercontent.com/12058428/106917553-a7f23600-6708-11eb-86fa-bdc94894c862.png";>
   Now I can press CTRL + field and see the full specs.
   <img width="643" alt="Screenshot 2021-02-04 at 16 48 06" 
src="https://user-images.githubusercontent.com/12058428/106917666-c6583180-6708-11eb-87cd-b7df201cd210.png";>
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org