dimberman commented on a change in pull request #14083:
URL: https://github.com/apache/airflow/pull/14083#discussion_r570473438



##########
File path: airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py
##########
@@ -271,6 +273,22 @@ def __init__(  # pylint: 
disable=too-many-arguments,too-many-locals
         self.client: CoreV1Api = None
         self.pod: k8s.V1Pod = None
 
+    def add_template_fields_to_env_vars(self, env_vars):

Review comment:
       @kaxil this is specific to the KPO as the k8s.V1EnvVar object doesn't 
have a templated_fields option. This problem only applies to fields that take 
in k8s objects. Do you have thoughts on other things that are the same?
   
   The thing you are pointing out says that the FIELD is templatable, but if 
the object within that field is a class that doesn't have a templated_fields 
field, then the render template function doesn't know what to do. All other 
elements in that list are strings or dictionaries so they shouldn't be an issue.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to