kaxil commented on a change in pull request #14090:
URL: https://github.com/apache/airflow/pull/14090#discussion_r570906769
##########
File path: airflow/kubernetes/pod_generator.py
##########
@@ -506,7 +506,7 @@ def reconcile_containers(base_containers,
'volume_mounts',
'mount_path')
client_container = extend_object_field(base_container,
client_container, 'env')
- client_container = extend_object_field(base_container,
client_container, 'env_from')
+ client_container = extend_object_field(base_container,
client_container, 'env_from', None)
Review comment:
Looks good but can you add a test case please in
https://github.com/apache/airflow/blob/v1-10-stable/tests/kubernetes/test_pod_generator.py?
Same as
https://github.com/apache/airflow/blob/v1-10-stable/tests/kubernetes/test_pod_generator.py#L636-L696
probably
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
