fuxiao224 commented on a change in pull request #13980:
URL: https://github.com/apache/airflow/pull/13980#discussion_r571204620



##########
File path: airflow/providers/google/cloud/operators/bigquery.py
##########
@@ -1862,6 +1862,13 @@ class BigQueryUpsertTableOperator(BaseOperator):
     :type delegate_to: str
     :param location: The location used for the operation.
     :type location: str
+    :param encryption_configuration: [Optional] Custom encryption 
configuration (e.g., Cloud KMS keys).

Review comment:
       Thanks for your comments! Yes, it makes sense to me. Does this mean that 
we need to close this PR since we don’t need to modify Airflow at all, or does 
it mean that our solution here probably wouldn’t fix the CMEK supporting issue 
in upsert function so that we need to keep digging into it? 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to