[
https://issues.apache.org/jira/browse/AIRFLOW-3540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16805324#comment-16805324
]
ASF GitHub Bot commented on AIRFLOW-3540:
-----------------------------------------
ashb commented on pull request #5006: [AIRFLOW-3540] Warn if old airflow.cfg
file is found
URL: https://github.com/apache/airflow/pull/5006
Make sure you have checked _all_ steps below.
### Jira
- [x] https://issues.apache.org/jira/browse/AIRFLOW-3540
### Description
- [x] People might have been caught by this situation of having (a dual
config file) without even knowning it. To make it obvious for those people we
should _say_ if we found the old config file even if we don't read from it.
**Note:** Against v1-10-stable branch, not master.
A DeprecationWarning may not actually be the right thing here, as we
aren't reading from it. Anyone have any thoughts?
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason: tested manually.
### Commits
- [x] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [x] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
### Code Quality
- [x] Passes `flake8`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Presence of ~/airflow/airflow.cfg shouldn't override config file settings
> -------------------------------------------------------------------------
>
> Key: AIRFLOW-3540
> URL: https://issues.apache.org/jira/browse/AIRFLOW-3540
> Project: Apache Airflow
> Issue Type: Improvement
> Reporter: Josh Carp
> Assignee: Josh Carp
> Priority: Trivial
> Fix For: 1.10.3
>
>
> If `~/airflow/airflow.cfg` exists, airflow uses that file instead of
> `$AIRFLOW_HOME/airflow.cfg`. This behavior is confusing. If `$AIRFLOW_HOME`
> is set and `$AIRFLOW_CONFIG` is not, we should only check
> `$AIRFLOW_HOME/airflow.cfg`.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
