yuqian90 commented on a change in pull request #14048:
URL: https://github.com/apache/airflow/pull/14048#discussion_r571452659



##########
File path: airflow/models/taskinstance.py
##########
@@ -166,13 +170,23 @@ def clear_task_instances(
                 ti.max_tries = max(ti.max_tries, ti.prev_attempted_tries)
             ti.state = State.NONE
             session.merge(ti)
+
+        tr_filter.append((ti.dag_id, ti.task_id, ti.execution_date, 
ti.try_number))

Review comment:
       Hi @turbaszek. I looked into `filter_for_tis()`. It specifically creates 
a filter for `TaskInstance`. In this case, we need to filter for 
`TaskReschedule` instead. Also, it does not include a condition for 
`try_number`, which is necessary to get `TaskReschedule` right. 
   
   ```python
           return or_(
               and_(
                   TaskInstance.dag_id == ti.dag_id,
                   TaskInstance.task_id == ti.task_id,
                   TaskInstance.execution_date == ti.execution_date,
               )
               for ti in tis
           )
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to