XD-DENG commented on a change in pull request #13906:
URL: https://github.com/apache/airflow/pull/13906#discussion_r571826925
##########
File path: chart/templates/webserver/webserver-deployment.yaml
##########
@@ -39,7 +39,7 @@ spec:
strategy:
type: RollingUpdate
rollingUpdate:
- maxUnavailable: 1
+{{ toYaml .Values.webserver.rollingUpdate | indent 6 }}
Review comment:
Do you mind addressing the comment above? I don't see it necessary to
use `toYaml` here.
> maybe more straight forward to have `maxUnavailable: {{
.Values.webserver.rollingUpdate.maxUnavailable }}` here. Let me know if you
have different opinion.
In addition, please also update the commit subject and add description
properly (that's what appear eventually in the commit history)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]