dstandish edited a comment on pull request #13423:
URL: https://github.com/apache/airflow/pull/13423#issuecomment-774741417


   hey @turbaszek @ashb @kaxil 
   
   rebased after merge of [BashOperator to raise AirflowSkipException on exit 
code 127](https://github.com/apache/airflow/pull/13421)
   
   that change has implications for this one
   
   what i have done for now is leave the exit code parsing in the hook's 
`run_command` method.
   
   i feel a little iffy about this.  i am tempted to have the hook return 
`namedtuple('SubprocessResult', ['exit_code', 'output'])` and let the operator 
decide what to do (skip fail or any other action)
   
   please let me know your thoughts on which way is best 🙏
   
   small sid note: i think will be nice to parameterize returning all output vs 
last line but this can be added in later pr.
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to