gglanzani commented on a change in pull request #4708: [AIRFLOW-3888] HA for
metastore connection
URL: https://github.com/apache/airflow/pull/4708#discussion_r270582868
##########
File path: tests/hooks/test_hive_hook.py
##########
@@ -282,6 +283,13 @@ def test_get_max_partition_from_valid_part_specs(self):
def test_get_metastore_client(self):
self.assertIsInstance(self.hook.get_metastore_client(), HMSClient)
+ @mock.patch("airflow.hooks.hive_hooks.HiveMetastoreHook.get_connection",
+ **{'return_value': [Connection(host="localhost", port=9802)]})
Review comment:
> Your scientists were so preoccupied with whether or not they could, they
didn’t stop to think if they should.
The suggested syntax does not work, indeed, when you have invalid
identifiers as keyword arguments. `return_value` is not one of them
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
