ashb commented on a change in pull request #14048:
URL: https://github.com/apache/airflow/pull/14048#discussion_r572166901
##########
File path: airflow/models/taskinstance.py
##########
@@ -166,13 +167,23 @@ def clear_task_instances(
ti.max_tries = max(ti.max_tries, ti.prev_attempted_tries)
ti.state = State.NONE
session.merge(ti)
+
+ tr_filter.append((ti.dag_id, ti.task_id, ti.execution_date,
ti.try_number))
+
+ if tr_filter:
# Clear all reschedules related to the ti to clear
- session.query(TR).filter(
- TR.dag_id == ti.dag_id,
- TR.task_id == ti.task_id,
- TR.execution_date == ti.execution_date,
- TR.try_number == ti.try_number,
- ).delete()
+ delete_qry = TR.__table__.delete().where(
+ or_(
+ and_(
+ TR.dag_id == dag_id,
+ TR.task_id == task_id,
+ TR.execution_date == execution_date,
+ TR.try_number == try_number,
+ )
+ for dag_id, task_id, execution_date, try_number in tr_filter
Review comment:
Yeah -- the performance difference is crazy for "large" queries in cases
like this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
