[GitHub] [airflow] ryanahamilton commented on a change in pull request #14144: Deactivate trigger, refresh, and delete controls on dag detail view.

[GitBox]

ryanahamilton commented on a change in pull request #14144:
URL: https://github.com/apache/airflow/pull/14144#discussion_r572518477



##########
File path: airflow/www/templates/airflow/dag.html
##########
@@ -109,13 +109,13 @@ <h4 class="pull-right" style="user-select: 
none;-moz-user-select: auto;">
       </div>
       <div class="col-md-2">
         <div class="btn-group pull-right">
-          <a href="{{ url_for('Airflow.trigger', dag_id=dag.dag_id, 
origin=url_for('Airflow.' + dag.default_view, dag_id=dag.dag_id)) }}" 
title="Trigger DAG" aria-label="Trigger DAG" class="btn btn-default 
btn-icon-only">
+          <a href="{{ url_for('Airflow.trigger', dag_id=dag.dag_id, 
origin=url_for('Airflow.' + dag.default_view, dag_id=dag.dag_id)) }}" 
title="Trigger DAG" aria-label="Trigger DAG" class="btn btn-default 
btn-icon-only {{ ' disabled' if not dag.can_trigger }}">
             <span class="material-icons" aria-hidden="true">play_arrow</span>
           </a>
-          <a href="{{ url_for('Airflow.refresh', dag_id=dag.dag_id) }}" 
title="Refresh DAG" aria-label="Refresh DAG" onclick="postAsForm(this.href); 
return false" class="btn btn-default btn-icon-only">
+          <a href="{{ url_for('Airflow.refresh', dag_id=dag.dag_id) }}" 
title="Refresh DAG" aria-label="Refresh DAG" onclick="postAsForm(this.href); 
return false" class="btn btn-default btn-icon-only {{ ' disabled' if not 
dag.can_edit }}">

Review comment:
       ```suggestion
             <a href="{{ url_for('Airflow.refresh', dag_id=dag.dag_id) }}" 
title="Refresh DAG" aria-label="Refresh DAG" onclick="postAsForm(this.href); 
return false" class="btn btn-default btn-icon-only{{ ' disabled' if not 
dag.can_edit }}">
   ```

##########
File path: airflow/www/templates/airflow/dag.html
##########
@@ -109,13 +109,13 @@ <h4 class="pull-right" style="user-select: 
none;-moz-user-select: auto;">
       </div>
       <div class="col-md-2">
         <div class="btn-group pull-right">
-          <a href="{{ url_for('Airflow.trigger', dag_id=dag.dag_id, 
origin=url_for('Airflow.' + dag.default_view, dag_id=dag.dag_id)) }}" 
title="Trigger DAG" aria-label="Trigger DAG" class="btn btn-default 
btn-icon-only">
+          <a href="{{ url_for('Airflow.trigger', dag_id=dag.dag_id, 
origin=url_for('Airflow.' + dag.default_view, dag_id=dag.dag_id)) }}" 
title="Trigger DAG" aria-label="Trigger DAG" class="btn btn-default 
btn-icon-only {{ ' disabled' if not dag.can_trigger }}">

Review comment:
       ```suggestion
             <a href="{{ url_for('Airflow.trigger', dag_id=dag.dag_id, 
origin=url_for('Airflow.' + dag.default_view, dag_id=dag.dag_id)) }}" 
title="Trigger DAG" aria-label="Trigger DAG" class="btn btn-default 
btn-icon-only{{ ' disabled' if not dag.can_trigger }}">
   ```

##########
File path: airflow/www/templates/airflow/dag.html
##########
@@ -109,13 +109,13 @@ <h4 class="pull-right" style="user-select: 
none;-moz-user-select: auto;">
       </div>
       <div class="col-md-2">
         <div class="btn-group pull-right">
-          <a href="{{ url_for('Airflow.trigger', dag_id=dag.dag_id, 
origin=url_for('Airflow.' + dag.default_view, dag_id=dag.dag_id)) }}" 
title="Trigger DAG" aria-label="Trigger DAG" class="btn btn-default 
btn-icon-only">
+          <a href="{{ url_for('Airflow.trigger', dag_id=dag.dag_id, 
origin=url_for('Airflow.' + dag.default_view, dag_id=dag.dag_id)) }}" 
title="Trigger DAG" aria-label="Trigger DAG" class="btn btn-default 
btn-icon-only {{ ' disabled' if not dag.can_trigger }}">
             <span class="material-icons" aria-hidden="true">play_arrow</span>
           </a>
-          <a href="{{ url_for('Airflow.refresh', dag_id=dag.dag_id) }}" 
title="Refresh DAG" aria-label="Refresh DAG" onclick="postAsForm(this.href); 
return false" class="btn btn-default btn-icon-only">
+          <a href="{{ url_for('Airflow.refresh', dag_id=dag.dag_id) }}" 
title="Refresh DAG" aria-label="Refresh DAG" onclick="postAsForm(this.href); 
return false" class="btn btn-default btn-icon-only {{ ' disabled' if not 
dag.can_edit }}">
             <span class="material-icons" aria-hidden="true">refresh</span>
           </a>
-          <a href="{{ url_for('Airflow.delete', dag_id=dag.dag_id) }}" 
title="Delete&nbsp;DAG" class="btn btn-default btn-icon-only"
+          <a href="{{ url_for('Airflow.delete', dag_id=dag.dag_id) }}" 
title="Delete&nbsp;DAG" class="btn btn-default btn-icon-only {{ ' disabled' if 
not dag.can_delete }}"

Review comment:
       ```suggestion
             <a href="{{ url_for('Airflow.delete', dag_id=dag.dag_id) }}" 
title="Delete&nbsp;DAG" class="btn btn-default btn-icon-only{{ ' disabled' if 
not dag.can_delete }}"
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org