[jira] [Commented] (AIRFLOW-4120) SLA of zero timedelta is not respected

[ASF subversion and git services (JIRA)]

    [ 
https://issues.apache.org/jira/browse/AIRFLOW-4120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16805515#comment-16805515
 ] 

ASF subversion and git services commented on AIRFLOW-4120:
----------------------------------------------------------

Commit 2614c02905a94fa36cddecb059768e41b5516f10 in airflow's branch 
refs/heads/master from Kamil Breguła
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=2614c02 ]

[AIRFLOW-4120] Modify SchedulerJob.manage_slas to respect zero timedelta SLAs 
(#4939) (#4894)

Modify SchedulerJob.manage_slas to respect zero timedelta SLAs

> SLA of zero timedelta is not respected
> --------------------------------------
>
>                 Key: AIRFLOW-4120
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-4120
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: models
>            Reporter: Markan Patel
>            Assignee: Simon Poortman
>            Priority: Minor
>             Fix For: 2.0.0
>
>
> When passing a zero timedelta SLA to any operator, it is not properly 
> respected if the task misses it.
>  
> {code:python}
> BaseOperator(
>   sla=timedelta(), # or timedelta(0)
>   **kwargs)
> {code}
> The cause can be narrowed down to the fact that
> {code:python}
> bool(timedelta()) == False
> {code}
> So any code that checks if the SLA parameter is falsy should be updated 
> accordingly.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)