bryanyang0528 commented on a change in pull request #5004: [AIRFLOW-4187]
SlackWebhookOperator do not pass http_conn_id to its parent class
URL: https://github.com/apache/airflow/pull/5004#discussion_r270493732
##########
File path: airflow/contrib/hooks/slack_webhook_hook.py
##########
@@ -95,6 +95,12 @@ def _get_token(self, token, http_conn_id):
raise AirflowException('Cannot get token: No valid Slack '
'webhook token nor conn_id supplied')
+ def _get_base_url(self):
Review comment:
This function is just to check if the `base_url` is correct. I removed this
one. Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
