potiuk edited a comment on issue #14281:
URL: https://github.com/apache/airflow/issues/14281#issuecomment-780794865


   > yes, It would be great if you can guide me along.
   
   I do not know much about presto - but when we join forces... 
   
   The gist of it is the Presto Operators to start using the client library you 
mentioned - so it has to be changed in `setup.py` - there is `presto` extra 
there and it has the dependencies there -> changing them to use Trino 
dependency is a good idea. 
   
   In fact we've already discussed renaming the provider to "trino" (we are 
aware of the name change) so a good start would  be to find all the places 
where "presto" is mentioned in the code and create a new provider `trino` that 
would be just copy of presto and you could use the new dependency in the new 
provider instead of the old one.
   
   That would be under "airflow/providers/presto" "tests/providers/presto", 
"docs/apache-airflow-providers-presto" and few other common places. 
   
   That would give a chance for Facebook to still maintain the presto provider 
if they want to. Then just switching imports to the new library should do the 
trick I believe :).
   
   That woudl be a good start. There is some more work needed to make 
integration tests working (we have a docker compose to run presto database). 
But we can worry about it next (@mik-laj implemented even a kerberos 
integration there) - happy to guide you trough the process when we get there. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to